Skip to content

Fix missing CSS-styling in production mode #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

workgena
Copy link
Contributor

@workgena workgena commented Oct 19, 2018

This PR is intended to fix styling error:

before after
Before After
  • Add Rails 5,2 and ActiveAdmin 1.3 to TravisCI
  • Fix spec with new CSS injection
  • Update README

@workgena workgena changed the title WIP: fix compatibility with ActiveAdmin 1.3 fix compatibility with ActiveAdmin 1.3 Oct 22, 2018
@workgena
Copy link
Contributor Author

@Fivell can you please check out why Travis CI does not run?

Expected — Waiting for status to be reported

@workgena workgena changed the title fix compatibility with ActiveAdmin 1.3 WIP: fix compatibility with ActiveAdmin 1.3 Oct 22, 2018
@Fivell
Copy link
Member

Fivell commented Oct 22, 2018

@workgena this is github issue , they have some problems now https://twitter.com/githubstatus

@workgena workgena force-pushed the compatibilty_with_activeadmin_1.3 branch from 90cb13e to 0393a86 Compare October 23, 2018 05:03
@workgena
Copy link
Contributor Author

workgena commented Oct 23, 2018

Looks like we have deprecated(not supported) configuration of Travis:

https://docs.travis-ci.com/user/legacy-services-to-github-apps-migration-guide/

As of May 2, 2018 we are moving toward having repositories integrated via a GitHub App instead of GitHub Services which will no longer be supported as of October 1, 2018.

@Fivell
Copy link
Member

Fivell commented Oct 23, 2018

@workgena are u able to migrate ?

@workgena
Copy link
Contributor Author

workgena commented Oct 23, 2018

@Fivell not, I can't login to Travis "activeadmin-plugins" namespace

@workgena workgena force-pushed the compatibilty_with_activeadmin_1.3 branch from 0393a86 to 3dbcb88 Compare October 30, 2018 14:17
@coveralls
Copy link

coveralls commented Oct 30, 2018

Coverage Status

Coverage decreased (-0.5%) to 94.774% when pulling a7731bf on workgena:compatibilty_with_activeadmin_1.3 into 081593e on activeadmin-plugins:master.

@workgena workgena force-pushed the compatibilty_with_activeadmin_1.3 branch 3 times, most recently from aa0f1a5 to f10dd9b Compare October 30, 2018 15:27
@workgena workgena changed the title WIP: fix compatibility with ActiveAdmin 1.3 fix compatibility with ActiveAdmin 1.3 Oct 31, 2018
@workgena
Copy link
Contributor Author

The problem was with bin/rails assets:precompile. It loses the content of "jquery.xdan.datetimepicker.css". The only working solution, I managed to find, is to use ActiveAdmin register_stylesheet method. It is DEPRECATED and will be removed in 2.0 version. But, for now, it works correctly. So I propose to use it.

# config/initializers/active_admin_datetimepicker.rb
ActiveAdmin.setup do |config|
  config.register_stylesheet 'jquery.xdan.datetimepicker.css'
end

Remove `poltergeist`. Replace it with Chrome-Headless
* add more versions
* use addons: chrome
@workgena workgena force-pushed the compatibilty_with_activeadmin_1.3 branch from 94ef4e3 to a7731bf Compare October 31, 2018 07:33
@workgena workgena changed the title fix compatibility with ActiveAdmin 1.3 Fix missing CSS-styling in production mode Oct 31, 2018
@Fivell
Copy link
Member

Fivell commented Oct 31, 2018

@workgena 👍 feel free to bump new version

@Fivell Fivell merged commit 44c9051 into activeadmin-plugins:master Oct 31, 2018
@benjaminwood
Copy link

FYI, it's not released yet but active admin has undeprecated register_stylesheet

activeadmin/activeadmin#5662

Guess it paid off to wait until active_admin provided a 'solution' 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants