Skip to content

Conversation

adamkiczula
Copy link
Contributor

I saw #62 had a help wanted tag so I figured I'd take a crack at it.

@coveralls
Copy link

coveralls commented Oct 25, 2019

Coverage Status

Coverage decreased (-0.02%) to 95.42% when pulling 27a2746 on adamkiczula:replace-chromedriver-helper into ee259aa on activeadmin-plugins:master.

@Fivell Fivell requested a review from workgena October 25, 2019 09:13
@adamkiczula
Copy link
Contributor Author

This is my first exposure to coveralls, but if I'm reading it right, it seems to be a false alarm. It did get me thinking though, should the generated test rails apps be included in the coverage numbers - seems less than desirable.

@workgena
Copy link
Contributor

Hi, @adamkiczula

Thank you for the contribution 💎

Have a nice weekend 🎈

@workgena workgena merged commit fa1d2ad into activeadmin-plugins:master Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants