-
Notifications
You must be signed in to change notification settings - Fork 100
spec for predefined foreign_key #41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b7a7099
to
771d851
Compare
spec/import_spec.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [82/80]
Use 2 (not 3) spaces for indentation.
771d851
to
3980713
Compare
spec/import_spec.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [129/80]
Redundant curly braces around a hash parameter.
Space found before comma.
Space inside parentheses detected.
3980713
to
f32212f
Compare
spec/import_spec.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end
at 63, 7 is not aligned with shared_examples 'successful inserts for author' do
at 54, 6
f32212f
to
b2f9d01
Compare
spec/import_spec.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [126/80]
Space found before comma.
Space inside parentheses detected.
b2f9d01
to
afebe24
Compare
spec/import_spec.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [124/80]
Indent the first parameter one step more than the previous line.
spec/import_spec.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
afebe24
to
2cf0756
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indent the first parameter one step more than the previous line.
236ad39
to
41f1b16
Compare
41f1b16
to
9447434
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [95/80]
…r_foreign_key spec for predefined foreign_key
Changes Unknown when pulling 9447434 on import_with_particular_foreign_key into * on master*. |
fixes #17