Skip to content

Conversation

Fivell
Copy link
Member

@Fivell Fivell commented Mar 17, 2015

fixes #17

@Fivell Fivell force-pushed the import_with_particular_foreign_key branch from b7a7099 to 771d851 Compare March 18, 2015 00:39

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [82/80]
Use 2 (not 3) spaces for indentation.

@Fivell Fivell force-pushed the import_with_particular_foreign_key branch from 771d851 to 3980713 Compare March 18, 2015 00:45

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [129/80]
Redundant curly braces around a hash parameter.
Space found before comma.
Space inside parentheses detected.

@Fivell Fivell force-pushed the import_with_particular_foreign_key branch from 3980713 to f32212f Compare March 18, 2015 00:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

end at 63, 7 is not aligned with shared_examples 'successful inserts for author' do at 54, 6

@Fivell Fivell force-pushed the import_with_particular_foreign_key branch from f32212f to b2f9d01 Compare March 18, 2015 00:48

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [126/80]
Space found before comma.
Space inside parentheses detected.

@Fivell Fivell force-pushed the import_with_particular_foreign_key branch from b2f9d01 to afebe24 Compare March 18, 2015 00:50

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [124/80]
Indent the first parameter one step more than the previous line.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.

@Fivell Fivell force-pushed the import_with_particular_foreign_key branch from afebe24 to 2cf0756 Compare March 18, 2015 00:54

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indent the first parameter one step more than the previous line.

@Fivell Fivell force-pushed the import_with_particular_foreign_key branch from 236ad39 to 41f1b16 Compare March 18, 2015 01:08
@Fivell Fivell force-pushed the import_with_particular_foreign_key branch from 41f1b16 to 9447434 Compare March 18, 2015 01:11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [95/80]

Fivell added a commit that referenced this pull request Mar 18, 2015
…r_foreign_key

spec for predefined foreign_key
@Fivell Fivell merged commit 8d78ff9 into master Mar 18, 2015
@Fivell Fivell deleted the import_with_particular_foreign_key branch March 18, 2015 06:52
@coveralls
Copy link

coveralls commented Oct 28, 2016

Coverage Status

Changes Unknown when pulling 9447434 on import_with_particular_foreign_key into * on master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Howto add default additional data to csv parsed from file?

3 participants