Fix installation for gem

[xfynx]

• freeze ransack version upto 1.8.6
• freeze rails version up to version 5.2
• kaminari-mongoid in requirements for index pages

due to issue #129 needs to freeze ransack version. ransack from version 1.8.7 is requiring active_record.
also ransack 1.8.6 is not supporting rails 5.2+, so freeze version for rails in test_app

[vfonic]

Wouldn't it be better to specify this as:

gem 'rails, '< 5.2'

?

'5.1.99' is not the highest possible '5.1.x' number after all. (5.1.100 is higher for example)

[vfonic]

LGTM.

I understand why devise is not included. Thanks!

[vfonic]

You could also add 'kaminari-mongoid' since it's required for index pages. 🎉

[grzegorz-jakubiak]

@deivid-rodriguez could you have a look at this? Though I don't know if we still need it.

[deivid-rodriguez]

I think ransack mongoid support seems to have been separated to a separate gem: https://github.com/activerecord-hackery/ransack-mongoid.

Sorry I can't be of much help but it's been a long time since I don't use mongodb. I only commented the other PR because I came across it, and it seemed straightforward.

[xfynx]

i've tried without ransack declaration and without rails freeze below 5.2, and without ransack tests are okay, but on newer rails from 5.2 it has ~14 failed specs. also, locking on rails <5.2 automatically locks ransack upto 1.8.6 too, so, i think, this PR is required

[deivid-rodriguez]

I think ransack mongoid support seems to have been separated to a separate gem: https://github.com/activerecord-hackery/ransack-mongoid.

I just noticed now that this gem is alread in the Gemfile. But is should probably be in the gemspec, just like kaminari-mongoid is?

Ideallysupport for Rails 5.2 and newer versions of ransack should be added, 14 failures does not seem much. But if nobody is able to do that job, then I agree limiting the dependencies to make the current status more clear is better.

[xfynx]

14 failures does not seem much

it is around a half of all specs in test app. and also i've tried earlier these all versions of gem in our production app, activeadmin was unworking.

okay, later i will try to fix this lock on rails and move this dependencies to gemspec.
a bit later do commit into this branch

[deivid-rodriguez]

it is around a half of all specs in test app. and also i've tried earlier these all versions of gem in our production app, activeadmin was unworking.

You're right, and even if it was only a small number of specs, it's not only about the number, but the importance of the specs and the difficulty to solve them. I didn't mean to say this is an easy job, my apologies!

okay, later i will try to fix this lock on rails and move this dependencies to gemspec.
a bit later do commit into this branch

Great, also you can take the chance to rebase the PR and fix the merge conflicts that have arised.

[xfynx]

i figured out.
https://github.com/activerecord-hackery/ransack-mongoid - we can't put this gem inside gemspec cause it's only on github. but i was able to drop this freezes and test app worked okay.
i think, in this situation we can do like this (drop the locks, remove usual ransack and so on), but ransack-mongoid needs to be described in readme as required gem to be put inside gemfile during installation. not perfect solution, but rails will not be locked.

[deivid-rodriguez]

Nice catch I agree with your plan. Once we have a working version as long as ransack-mongoid is manually installed via pointing to github's master in the final application's Gemfile, we can go over to the ransack-mongoid repo and request an initial release.

[xfynx]

okay, then later on this week (tomorrow probably) i'll do this

[xfynx]

closed as non-relevant, proceed to #133