-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combobox options expand on tab #640
Combobox options expand on tab #640
Conversation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you! Maintainer checklist
|
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -29,6 +30,7 @@ | |||
> | |||
<ComboboxOptions | |||
class="absolute mt-1 max-h-60 w-full overflow-auto rounded-md bg-light-distinct dark:bg-dark-distinct py-1 text-base elem-shadow-lg ring-1 ring-black/5 focus:outline-none sm:text-sm" | |||
id="isVisibleElement" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just need the id
to go above class here given the eslint order, @UnknownSean8 :) Also happy to do this myself!
Haha you were too fast! Thanks @UnknownSean8! |
Haha, I haven't actually read your comment just now, but I forgot to do the formatting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally really wonderful to use and code well very well implemented ✅ Thanks so much for this, @UnknownSean8! Really a pleasure to communicate and work with you on this 😊 Hope you contribute again!
Thank you as well, was looking for a project to improve on my VueJS skills and I believe I can learn a lot by contributing to your project. I will contribute to other issues that I see fit soon. It was a pleasure to communicate with you as well. |
Contributor checklist
Description
Fixes Issue #618. Tabbing into the combo box will now have the same functionality as clicking into it. The second commit is just adding comments.
Related issue