Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox options expand on tab #640

Merged
merged 4 commits into from
Dec 30, 2023

Conversation

UnknownSean8
Copy link
Contributor

Contributor checklist


Description

Fixes Issue #618. Tabbing into the combo box will now have the same functionality as clicking into it. The second commit is just adding comments.

Related issue

Copy link
Contributor

github-actions bot commented Dec 30, 2023

Thank you for the pull request!

The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo
  • The TypeScript and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

Copy link

netlify bot commented Dec 30, 2023

Deploy Preview for activist-org ready!

Name Link
🔨 Latest commit d360062
🔍 Latest deploy log https://app.netlify.com/sites/activist-org/deploys/659057914fac170008dc0026
😎 Deploy Preview https://deploy-preview-640--activist-org.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andrewtavis andrewtavis self-requested a review December 30, 2023 17:40
@@ -29,6 +30,7 @@
>
<ComboboxOptions
class="absolute mt-1 max-h-60 w-full overflow-auto rounded-md bg-light-distinct dark:bg-dark-distinct py-1 text-base elem-shadow-lg ring-1 ring-black/5 focus:outline-none sm:text-sm"
id="isVisibleElement"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need the id to go above class here given the eslint order, @UnknownSean8 :) Also happy to do this myself!

@andrewtavis
Copy link
Member

Haha you were too fast! Thanks @UnknownSean8!

@UnknownSean8
Copy link
Contributor Author

Haha, I haven't actually read your comment just now, but I forgot to do the formatting.

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally really wonderful to use and code well very well implemented ✅ Thanks so much for this, @UnknownSean8! Really a pleasure to communicate and work with you on this 😊 Hope you contribute again!

@andrewtavis andrewtavis merged commit 9ac0fb5 into activist-org:main Dec 30, 2023
6 checks passed
@UnknownSean8
Copy link
Contributor Author

Thank you as well, was looking for a project to improve on my VueJS skills and I believe I can learn a lot by contributing to your project.

I will contribute to other issues that I see fit soon. It was a pleasure to communicate with you as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants