New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFE: add a possibility to change POI rendering #3

Open
jose1711 opened this Issue Oct 29, 2015 · 7 comments

Comments

Projects
None yet
2 participants
@jose1711

jose1711 commented Oct 29, 2015

it would be nice to modify a default "black dot" rendering of POIs to icons/symbols/etc.

@activityworkshop

This comment has been minimized.

Owner

activityworkshop commented Jan 3, 2016

Thanks for the suggestion. This has already been proposed here: http://sourceforge.net/p/prune-gps/discussion/682167/thread/08402fdf/
but it's still not clear how to go about it.

My Garmin device saves waypoints in gpx files by default with a value of "Flag, Blue" and if I change the symbol in the device then I get other values like "Restaurant" or "Campground" or "Summit". So I think that what you want is for GpsPrune to look at these values and try to find a graphics file with a corresponding name, am I right?

Even if we assume that all Garmin devices save the same values regardless of what language they're set to (I haven't tried that out yet), I think it's very unlikely that other Garmin devices or devices from other manufacturers will use the same English strings - I can't find anything in the GPX spec which says what the valid values are.
Secondly, I can't redistribute the Garmin symbols because they belong to Garmin. And similarly for other manufacturers and their symbols. So it's going to look different anyway. Unless you're suggesting that GpsPrune allows you to select from its own set of symbols, just for its own display? Do you have a set of open symbols in mind?

@jose1711

This comment has been minimized.

jose1711 commented Jan 3, 2016

tbh my proposal was far more simple. all i imagined was a dialog to change dot to something else. be it a tiny black/white circle, flag, green pin. i believe what you are referring to is called garmin typ files: http://wiki.openstreetmap.org/wiki/Mkgmap/help/TYP_files

as i don't own a garmin device i cannot comment much on this one though.

@activityworkshop

This comment has been minimized.

Owner

activityworkshop commented Jan 26, 2016

To help the discussion I attach some examples of what I think you're suggesting.

example_icons
I guess it shouldn't be too difficult to let the user select one of these icons from the Settings menu, and use the selected icon for all waypoints (and save the choice in the settings). The main problem I can see is that any of those icons would necessarily obscure some of the track points around the waypoint, mostly to the north or northeast. I assume that the icon size is fixed and independent of the zoom level, so zooming in would help to see the track points, but even so some may still be hidden by the waypoint icon.
Thoughts?

@jose1711

This comment has been minimized.

jose1711 commented Feb 5, 2016

hello,

my initial thoughts were that this was only going to be used for a special
cases like: i don't care about track points, very likely all i want to have
displayed is the set of waypoints. but even if they'd be hidden behind the
symbols, it would work for me.

jose

On Tue, Jan 26, 2016 at 9:23 PM, activityworkshop notifications@github.com
wrote:

To help the discussion I attach some examples of what I think you're
suggesting.

[image: example_icons]
https://cloud.githubusercontent.com/assets/11003522/12593637/5cd38a72-c472-11e5-83dc-f3d7063b158f.png
I guess it shouldn't be too difficult to let the user select one of these
icons from the Settings menu, and use the selected icon for all waypoints
(and save the choice in the settings). The main problem I can see is that
any of those icons would necessarily obscure some of the track points
around the waypoint, mostly to the north or northeast. I assume that the
icon size is fixed and independent of the zoom level, so zooming in would
help to see the track points, but even so some may still be hidden by the
waypoint icon.
Thoughts?


Reply to this email directly or view it on GitHub
#3 (comment)
.

Ing. Jozef Riha
IBM Certified Specialist: pSeries Administration and Support

._
) Registered Linux user: #314375
Registered member of freemap.sk

@activityworkshop

This comment has been minimized.

Owner

activityworkshop commented Aug 20, 2016

You might be interested in the screenshots posted to the development page:
http://gpsprune.activityworkshop.net/development.html
This shows the first draft of the icon selection dialog, and an example of the rendering on the map. The code isn't ready to release yet but any feedback is still welcome :)

@jose1711

This comment has been minimized.

jose1711 commented Aug 21, 2016

Hello, this looks very nice. Will a user have a possibility to add custom
icons by - say - placing icon images into a corresponding directory?

Thank you,

jose

On Sat, Aug 20, 2016 at 9:16 PM, activityworkshop notifications@github.com
wrote:

You might be interested in the screenshots posted to the development page:
http://gpsprune.activityworkshop.net/development.html
This shows the first draft of the icon selection dialog, and an example of
the rendering on the map. The code isn't ready to release yet but any
feedback is still welcome :)


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABV1DpCRkglKvEcEUcwAZb8RhzqE1PAUks5qh1KKgaJpZM4GYN-D
.

Ing. Jozef Riha
IBM Certified Specialist: pSeries Administration and Support

._
) Registered Linux user: #314375
Registered member of freemap.sk

@activityworkshop

This comment has been minimized.

Owner

activityworkshop commented Sep 11, 2016

Probably not in this first release, no. They will be a fixed set of options to choose from, but no option to add your own icon image.

Adding your own images will come later, as it fits together well with the other wishlist item proposing different icons for different waypoint types. This is rather less straightforward because with unknown images, GpsPrune doesn't know where to draw them relative to the marked point. For example, the ring icon above is drawn right on top of the point (so the point is behind the middle of the circle), whereas the pin icon points to the marked position at the tip of the pin in the bottom left of the image. If the user can specify their own image then they also need to be able to specify where the "point" is inside this image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment