-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-export all error types from awc #1621
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1621 +/- ##
=======================================
Coverage 53.20% 53.20%
=======================================
Files 125 125
Lines 11762 11762
=======================================
Hits 6258 6258
Misses 5504 5504
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no objections for this. Could you also update the changelog?
Should I not add any other imports (or do any of the other options listed above)? |
I would be in favour of re exporting all the error types as you mentioned in 2. |
We'd be happy to include this in the next beta release if you could update in a few days :) |
522257d
to
062f46b
Compare
Done! I also noticed the change log has a bad link:
I can fix that as well, unless you wanted to keep that separate? |
might as well since you spotted it 👍 |
PR Type
Other
PR Checklist
Check your PR fulfills the following:
Overview
This makes using error handling while using the
awc::Client
much easier.Closes #1474
Or I can update this PR to do one of the following (in order of ascending levels of change):
Import the rest of the missing
errors
(and the rest of the API as well?) likeFrozenClientRequest
individually.Change the
error
imports to:Change the whole
client
module to:awc
(breaking change):