Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify AnyBody and BodySize #2446

Merged
merged 4 commits into from
Nov 16, 2021
Merged

simplify AnyBody and BodySize #2446

merged 4 commits into from
Nov 16, 2021

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Nov 16, 2021 •
edited
Loading

PR Type

Refactor

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

  • Remove Empty variants of AnyBody and BodySize.
  • Rename AnyBody::{Message => Stream}.

@robjtede robjtede added B-semver-major breaking change requiring a major version bump A-http project: actix-http labels Nov 16, 2021
@robjtede robjtede changed the title simplify AnyBody and BodySize simplify AnyBody and BodySize Nov 16, 2021
@robjtede robjtede requested a review from a team November 16, 2021 01:48
JohnTitor
JohnTitor approved these changes Nov 16, 2021
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, +1

@robjtede robjtede merged commit 4df1cd7 into master Nov 16, 2021
@robjtede robjtede deleted the simplify-anybody branch November 16, 2021 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

@popzxc popzxc popzxc approved these changes

Assignees
No one assigned
Labels
A-http project: actix-http B-semver-major breaking change requiring a major version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robjtede @popzxc @JohnTitor