Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Allow header to resource's default 405 handler #2949

Merged
merged 4 commits into from
Dec 21, 2022
Merged

add Allow header to resource's default 405 handler #2949

merged 4 commits into from
Dec 21, 2022

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Dec 21, 2022 •
edited
Loading

PR Type

Fix

PR Checklist

  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • A changelog entry has been made for the appropriate packages.
  • Format code with the latest stable rustfmt.
  • (Team) Label with affected crates and semver status.

Overview

Spec says MUST so...

closes #2359

@robjtede robjtede added A-web project: actix-web B-semver-patch labels Dec 21, 2022
@robjtede robjtede marked this pull request as ready for review December 21, 2022 00:33
@robjtede robjtede added this to the actix-web v4.3 milestone Dec 21, 2022
JohnTitor
JohnTitor approved these changes Dec 21, 2022
View reviewed changes
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec says MUST so...

TIL, thank you for the fix!

actix-web/src/guard/mod.rs Outdated Show resolved Hide resolved
actix-web/src/resource.rs Outdated Show resolved Hide resolved
@robjtede robjtede merged commit 06c3513 into master Dec 21, 2022
@robjtede robjtede deleted the fix-405 branch December 21, 2022 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnTitor JohnTitor JohnTitor approved these changes

Assignees
No one assigned
Labels
A-web project: actix-web B-semver-patch
Projects
None yet
Milestone
actix-web v4.3
Development

Successfully merging this pull request may close these issues.

allow response header missing for 405 Method Not Allowed generated by router
2 participants
@robjtede @JohnTitor