remove unusable create_app example #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnTitor
reviewed
Feb 16, 2020
robjtede
force-pushed
the
remove-create-app
branch
from
5b85cd0
to
85228f2
Compare
JohnTitor
approved these changes
Feb 17, 2020
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is noted in actix/actix-web#1156 and actix/actix-web#1190 that returning the App struct from a function is difficult. This section of the website doesn't work, citing trait bound errors.
I've tried, but if someone can figure out how to make this pattern work then we can change it to that instead.