Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some clang tidy fixes #1512

Merged
merged 2 commits into from
Aug 4, 2023
Merged

Some clang tidy fixes #1512

merged 2 commits into from
Aug 4, 2023

Conversation

riemass
Copy link
Member

@riemass riemass commented Aug 4, 2023

Related #1435

This clears 3 bugprone checks:
-bugprone-move-forwarding-reference - fixed,
-bugprone-macro-parentheses - tried putting parentheses, it broke our solution. Just ignoring it for now seems reasonable,
-bugprone-easily-swappable-parameters - ignoring it as discussed, since we have multiple occurrences of this and sub-typing every time would complicate stuff.

@riemass riemass requested a review from Neverlord August 4, 2023 15:09
@riemass riemass changed the title Topic/riemass/clang tidy Some clang tidy fixes Aug 4, 2023
Copy link
Member

@Neverlord Neverlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.06% 🎉

Comparison is base (b618678) 65.91% compared to head (bce338e) 65.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1512      +/-   ##
==========================================
+ Coverage   65.91%   65.97%   +0.06%     
==========================================
  Files         636      636              
  Lines       27064    27064              
  Branches     2954     2955       +1     
==========================================
+ Hits        17839    17856      +17     
+ Misses       7696     7683      -13     
+ Partials     1529     1525       -4     
Files Changed Coverage Δ
libcaf_core/caf/config_value.hpp 68.94% <100.00%> (ø)
libcaf_core/caf/flow/op/concat.hpp 78.75% <100.00%> (ø)
libcaf_core/caf/policy/select_all.hpp 91.48% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neverlord Neverlord merged commit 7081bef into master Aug 4, 2023
9 checks passed
@Neverlord Neverlord deleted the topic/riemass/clang-tidy branch August 4, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants