feat: save vertex seed

[felix-russo]

Saves 4D of the vertex seed (its x- and y- coordinate are not estimated in current seeding algorithms and should be set to 0).

[codecov]

Codecov Report

Attention: Patch coverage is 58.82353% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 48.67%. Comparing base (b7f6cc0) to head (3e35e28).

Files	Patch %	Lines
Core/src/Vertexing/Vertex.cpp	58.82%	9 Missing and 5 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2885      +/-   ##
==========================================
- Coverage   48.68%   48.67%   -0.01%     
==========================================
  Files         493      493              
  Lines       29053    29055       +2     
  Branches    13854    13853       -1     
==========================================
- Hits        14144    14143       -1     
- Misses       4963     4966       +3     
  Partials     9946     9946              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

📊: Physics performance monitoring for 3e35e28

Full contents

physmon summary

• ✅ CKF truth_smeared
• ✅ IVF truth_smeared
• ✅ AMVF truth_smeared
• ✅ Track Summary CKF truth_smeared
• ✅ Seeding truth_estimated
• ✅ CKF truth_estimated
• ✅ IVF truth_estimated
• ✅ AMVF truth_estimated
• ✅ Track Summary CKF truth_estimated
• ✅ Seeding seeded
• ✅ CKF seeded
• ✅ IVF seeded
• ✅ AMVF seeded
• ✅ AMVF (+grid seeder) seeded
• ✅ Track Summary CKF seeded
• ✅ Seeding orthogonal
• ✅ CKF orthogonal
• ✅ IVF orthogonal
• ✅ AMVF orthogonal
• ✅ Track Summary CKF orthogonal
• ✅ Ambisolver seeded
• ✅ Ambisolver orthogonal
• ✅ Seeding ttbar
• ✅ CKF ttbar
• ✅ Ambisolver
• ✅ Track Summary CKF ttbar
• ✅ AMVF ttbar
• ✅ AMVF (+grid seeder) ttbar
• ✅ Truth tracking (GSF)
• ✅ Truth tracking
• ✅ Truth tracking (GX2F)
• ✅ Particles fatras
• ✅ Particles geant4

[andiwand]

that's a good idea!

at some point we may want to split this performance writer because it already does a couple of things at the same time. but this is not relevant for you

[felix-russo]

Do you have any idea why recoOverAcc, recoOverRecbl, and recoOverTrue differ in the physmon?

These quantities are just divisions of nTrueVtx, nRecoVtx, and nTrueVtx, etc., which align exactly...

I am quite puzzled @andiwand @paulgessinger

[paulgessinger]

@felix-russo i think they're reconstructed vertices over all vertices, reconstructible only and vertices in the acceptance only.

So I don't think they should be identical.

[felix-russo]

Found the mistake 🥳

[paulgessinger]

And are you sure they're different? I think the jobs are just red because the new histograms are missing in the references.

[felix-russo]

And are you sure they're different? I think the jobs are just red because the new histograms are missing in the references.

The mistake was in the previous versions of the code. 5 minutes before you commented the physmon was updated and looks fine now! Thanks for looking at this on the weekend :) @paulgessinger

[felix-russo]

Here are some histograms of the seed coordinates and of the residuals for amvf + gridseeder seeded. The seed's x- and y-coordinate are 0 as expected (the mean value of 0.0006 comes because the central bin is not exactly at 0). Marking this PR as ready for review...

[andiwand]

resolved the conflicts - waiting for physmon to complete to update refs

[acts-project-service]

✅ Athena integration test results [2664480]

✅ All tests successful

status	job	report
🟢	run_unit_tests
🟢	test_ActsEFTrackFit
🟢	test_ActsBenchmarkWithSpot
🟢	test_ActsConversionWorkflow
🟢	test_ActsWorkflow
🟢	test_ActsValidateAmbiguityResolution
🟢	test_ActsValidateResolvedTracks
🟢	test_ActsValidateTracks
🟢	test_ActsValidateActsCoreSpacePoints
🟢	test_ActsValidateActsSpacePoints
🟢	test_ActsValidateSeeds
🟢	test_ActsValidateOrthogonalSeeds
🟢	test_ActsValidateClusters
🟢	test_ActsPersistifyEDM
🟢	test_ActsGSFRefitting
🟢	test_ActsKfRefitting
🟢	test_ActsExtrapolationAlgTest
🟢	test_ActsITkTest
🟢	run_workflow_tests_run4_mc
🟢	run_workflow_tests_run2_mc
🟢	run_workflow_tests_run2_data
🟢	run_workflow_tests_run3_mc
🟢	run_workflow_tests_run3_data
🟢	run_art_test: test_data18_13TeV_1000evt
🟢	run_art_test: test_ttbarPU40_reco