ci: Enable "fail on error" in CI #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HadrienG2
added
🚧 WIP
Codecov Report
@@ Coverage Diff @@
## master #688 +/- ##
==========================================
+ Coverage 49.01% 49.02% +0.01%
==========================================
Files 325 325
Lines 16574 16574
Branches 7744 7744
==========================================
+ Hits 8124 8126 +2
+ Misses 3019 3017 -2
Partials 5431 5431
Continue to review full report at Codecov.
|
|
This is now ready for review. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is taking #687 to its logical conclusion.
It should not be merged yet because...It's based on feat: Allow the build to be configured in "fail on error" mode #687 and fix: Fix confusion between shadowed variables in the AtlasStepperTests #690 , which should be merged first.The new behavior uncovered a few interesting issues in the AtlasStepperTests that must be resolved before CI is green again.=> Fixed by fix: Fix confusion between shadowed variables in the AtlasStepperTests #690