Skip to content

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Apr 20, 2023

When BUILD_TESTING flag is disabled, build crashes at the moment. This is due to the missing import.cmake statement inside tools folder.

An example error from the homebrew pull request:

Ref: https://github.com/Homebrew/homebrew-core/actions/runs/4737212538/jobs/8409814274?pr=128710

Logs

==> cmake -B build -DCMAKE_INSTALL_PREFIX=/opt/homebrew/Cellar/ada/2.1.0 -DCMAKE_INSTALL_LIBDIR=lib -DCMAKE_BUILD_TYPE=Release -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_VERBOSE_MAKEFILE=ON -Wno-dev -DBUILD_TESTING=OFF -DCMAKE_OSX_SYSROOT=/Library/Developer/CommandLineTools/SDKs/MacOSX11.sdk
-- The C compiler identification is AppleClang 13.0.0.13000029
-- The CXX compiler identification is AppleClang 13.0.0.13000029
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /opt/homebrew/Library/Homebrew/shims/mac/super/clang - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /opt/homebrew/Library/Homebrew/shims/mac/super/clang++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Code formatting is not enabled.
-- Compiler ID : AppleClang
-- CMAKE_BUILD_TYPE : Release
-- Assuming GCC-like compiler.
-- Found Python3: /opt/homebrew/bin/python3.11 (found version "3.11.3") found components: Interpreter 
-- Python found, we are going to amalgamate.py.
CMake Error at tools/CMakeLists.txt:5 (import_dependency):
  Unknown CMake command "import_dependency".

@anonrig anonrig requested a review from lemire April 20, 2023 21:14
@anonrig
Copy link
Member Author

anonrig commented Apr 20, 2023

Easiest way to reproduce cmake -B build -G Ninja -DBUILD_TESTING=OFF

@anonrig anonrig merged commit 1d24ce9 into main Apr 20, 2023
@anonrig anonrig deleted the fix-brew branch April 20, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants