New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): add support for using wasm threads #49

Merged

anonrig merged 1 commit into ada-url:main from d3lm:delm/feat/threads-support

Sep 5, 2023

Member

d3lm commented Sep 5, 2023

This PR adds support for integrating this crate into a multi-threaded application that enables the atomics feature.

anonrig approved these changes

View reviewed changes


          feat(build): add support for using wasm threads

db09275

d3lm commented

View reviewed changes

deps/wasi_to_unknown.cpp

@@ @@ -43,6 +43,10 @@ int32_t __imported_wasi_snapshot_preview1_fd_write(int32_t, @@
                 __builtin_unreachable();
               }
+              int32_t __imported_wasi_snapshot_preview1_sched_yield() {

Member Author

d3lm Sep 5, 2023

This is needed when using wasm32-wasi-threads and it's ok to just noop it.

anonrig merged commit a7d58d3 into ada-url:main

6 checks passed

d3lm deleted the delm/feat/threads-support branch

September 5, 2023 13:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment