-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add getter for scheme type #52
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
reviewed
Sep 5, 2023
I recommend waiting for the function name change to merge this pull request. |
Yes, agreed. Updated the function name to |
anonrig
requested changes
Sep 5, 2023
d3lm
changed the title
feat: add getter for schema type
feat: add getter for scheme type
Sep 5, 2023
PR updated to latest |
anonrig
force-pushed
the
delm/feat/schema-type
branch
from
September 5, 2023 21:20
803674f
to
ac9600b
Compare
anonrig
approved these changes
Sep 5, 2023
Thank you for your contribution @d3lm. Appreciate it! |
Thank you for the quick response times and reviewing all those PRs as well as cutting new releases that quickly 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #51 and adds a new getter to retrieve the schema type.
Todo