Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add getter for scheme type #52

Merged
merged 4 commits into from
Sep 5, 2023
Merged

feat: add getter for scheme type #52

merged 4 commits into from
Sep 5, 2023

Conversation

d3lm
Copy link
Member

@d3lm d3lm commented Sep 5, 2023

This PR addresses #51 and adds a new getter to retrieve the schema type.

Todo

@d3lm d3lm requested a review from anonrig September 5, 2023 17:39
deps/ada.cpp Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@d3lm d3lm requested a review from anonrig September 5, 2023 18:21
@anonrig
Copy link
Member

anonrig commented Sep 5, 2023

I recommend waiting for the function name change to merge this pull request.

@d3lm
Copy link
Member Author

d3lm commented Sep 5, 2023

Yes, agreed. Updated the function name to scheme.

src/ffi.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@d3lm d3lm changed the title feat: add getter for schema type feat: add getter for scheme type Sep 5, 2023
@d3lm d3lm requested a review from anonrig September 5, 2023 21:14
@d3lm
Copy link
Member Author

d3lm commented Sep 5, 2023

PR updated to latest main.

@anonrig anonrig merged commit 762ee3e into main Sep 5, 2023
6 checks passed
@anonrig anonrig deleted the delm/feat/schema-type branch September 5, 2023 21:21
@anonrig
Copy link
Member

anonrig commented Sep 5, 2023

Thank you for your contribution @d3lm. Appreciate it!

@d3lm
Copy link
Member Author

d3lm commented Sep 5, 2023

Thank you for the quick response times and reviewing all those PRs as well as cutting new releases that quickly 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants