Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constants and board selection for Orange Pi 5 Plus #742

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

Barbarian-5215
Copy link
Contributor

I based the new module OrangePi5Plus.py on documentation provided by Orange Pi, from it's wiki page for the 5 plus. I am confident of the the GPIO mappings, but less so with the UART, I2C, PWM settings, as they match the Orange Pi values provided, but seem to conflict with the values in src/adafruit_blinka/microcontroller/rockchip/rk3588/pin.py.

@makermelissa
Copy link
Collaborator

Waiting on adafruit/Adafruit_Python_PlatformDetect#327 to be merged and released...

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@makermelissa makermelissa merged commit 11c92fd into adafruit:main Nov 29, 2023
1 check passed
@drozdi70
Copy link

as in #692 I guess pin.py file should be also adjusted.... :)
orange pi 5 uses RK3588S , orange pi 5 plus uses RK3588

@makermelissa
Copy link
Collaborator

makermelissa commented Nov 29, 2023

@drozdi70 I'm a little unclear on your suggestion. Are you saying:

  1. We should make a RK3588S pin.py file for the Orange Pi 5?
  2. Or that the current RK3588 pin.py file is incorrectly named and is actually supposed to be for the RK3588S and we need a correct RK3588S pin.py file?
  3. Something else?

@drozdi70
Copy link

drozdi70 commented Nov 29, 2023 via email

@makermelissa
Copy link
Collaborator

Hi Im saying that pin.py file works only for orange pi 5 board.For orange pi 5 plus is incorrect. that's why as workaround I replace such a file with mine as in #692:sudo cp -f orangepi5plus.py /usr/local/lib/python3.11/dist-packages/adafruit_blinka/board/orangepi/orangepi5.py sudo cp -p pin5plus.py /usr/local/lib/python3.11/dist-packages/adafruit_blinka/microcontroller/rockchip/rk3588/pin.pyhow do you discover board_id is ORANGE_PI_5_PLUS not ORANGE_PI_5?on my orange pi 5 plus when I run your @.:~/work$ sudo python3 blinka_test.pyHello blinka!Board id is:  ORANGE_PI_5Digital IO ok!I2C  bus 2 ok!I2C default 2 ok!SPI @.:~/work$ more blinka_test.pyimport boardimport digitalioimport busioimport sysimport adafruit_platformdetect.constants.boards as ap_boardfrom adafruit_blinka.agnostic import board_id, detectorprint("Hello blinka!")print("Board id is: ",board_id)# Try to great a Digital input#pin = digitalio.DigitalInOut(board.PA6) --not needed nowprint("Digital IO ok!")# Try to create an I2C devicei2c = busio.I2C(board.I2C2_SCL_M0, board.I2C2_SDA_M0)print("I2C  bus 2 ok!")i2c = busio.I2C(board.SCL, board.SDA)print("I2C default 2 ok!")# Try to create an SPI device#spi = busio.SPI(board.SCLK, board.MOSI, board.MISO) --not needed nowprint("SPI ok!")print("done!")RegardsRobertTemat: Re: [adafruit/Adafruit_Blinka] Add constants and board selection for Orange Pi 5 Plus (PR #742)Data: 2023-11-29 21:10Nadawca: "Melissa LeBlanc-Williams" @.>Adresat: "adafruit/Adafruit_Blinka" @.>; DW: "DroZDi" @.>; "Mention" @.>; @drozdi70 I'm a little unclear on your suggestion. Are you saying: We should make a RK3588S pin.py file for the Orange Pi 5? Or that the current RK3588 pin.py file is incorrectly names and is actually supposed to be for the RK3588S and we need a correct RK3588S pin.py file? Something else? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Ok, sounds like the second option I mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants