Add Orange Pi 5 Plus to board detection #327
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a constant for ORANGE_PI_5_PLUS
Added detection of Orange Pi 5 Plus
|
It looks like you will need to add ORANGE_PI_5_PLUS as a constant to https://github.com/adafruit/Adafruit_Python_PlatformDetect/blob/main/adafruit_platformdetect/constants/boards.py I would also check for "Orange Pi 5 Plus" before "Orange Pi 5" or else it will incorrectly be detected as ORANGE_PI_5. |
Changed order of discovery, 5 plus, then 5.
Added literal definition for ORANGE_PI_5_PLUS
|
I made the needed changes in platform detect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following existing patterns, I added logic to handle the new board. I verified the literal values with the /etc/armbian-release file.