Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

framing masks #20

Open
jedgarpark opened this issue Jan 16, 2024 · 4 comments
Open

framing masks #20

jedgarpark opened this issue Jan 16, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@jedgarpark
Copy link

it would be great to add optional framing masks to match the different resolutions/aspect ratios. Either viewfinder-style outline or full black blocking mask so you can properly frame in the viewfinder.

@jedgarpark jedgarpark added the enhancement New feature or request label Jan 16, 2024
@jepler
Copy link
Member

jepler commented Mar 4, 2024

@FoamyGuy does your code help with this at all?

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Mar 4, 2024

I looked at this one a few times and did think about it a bit. I am not certain that I understand fully what this means but based on how I think I understand it I do think the overlay feature can help with this.

I do think it depends a little bit on how the preview vs. photo saving works. I haven't paid super close attention to figure out if the current preview represents the entirety of the saved photo or if some of it gets cut off. The different possible resolution settinfs could factor into that as well, so far I've only used the overlay with the smallest few settings.

In order to be used we would need to get a set of aspect ratio frame images created and scaled properly to fit the preview window. For the larger ones it may be necessary to create them smaller and utilize the scaling from #33 so that they can fit into memory.

@jedgarpark
Copy link
Author

right on, yes, I think an overlay of a thin grey rectangle would be good so that it's clear when you're framing a shot what exactly will be in the photo. this sort of thing but just one rectangle and it varies ratio with the preset resolutions.

@jedgarpark
Copy link
Author

I made a photoshop document that has all of the sizes at true scale, but i could conform all of those to screen size with proper ratios if needed.
Screenshot 2024-03-04 at 1 05 43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants