-
Notifications
You must be signed in to change notification settings - Fork 129
Conversation
* Added Pair, ConnectProfile. In Pair, it wouldn't work without also supplying reply_handler and error_handler. Added ConnectProfile, which is the only way I could find to enumerate a custom GattService1. For some reason, GattServices property updated via the property updates, but produces an error when querying the property directly. The BluezGattService also tracks it's given object path as well.
This allows processes to use this in a method and re-uses the results.
Howdy, I cleaned up some of the dbus changes I needed for bewest#1, https://github.com/bewest/openxshareble. In particular, I found the UART class and examples very very helpful, thanks! |
LGTM |
Aside, there's some useful stuff in #7, I'm wondering if we can maybe sync up. |
Aside, dbus-python is older, pydbus is the newer thing For posterity:
The updates in glib 2.45 are really only needed in the scenario where someone needs to export services on dbus by using ble. In scenarios like this, the older I've spent several weeks evaluating pydbus, which really needs glib 2.45 to work, vs txdbus, versus the limitations of the older API. The older API can be worked around in my scenario by promoting variety of "background threads" to full blown processes, all using the older API. However, it's not really open to new features or patches (eg to workaround properties), and pydbus is, pending glib 2.45 becoming more widely available. I took a very brief stab at duplicating a lot of things to adapt the pydbus methods with minimal changes. One big change I mad was eliminating the Sad attempt: bewest#3
P.P.S., again for posterity |
add instructions for installing python-dbus
Is this something that can be merged? Or do we need to create a fork over at https://github.com/openaps/ for ongoing openxshareble support? |
@adafruit can you tell us if this library is still updated, or we should fork it and maintain it. It's used as part of openaps. We need these patches and donatieng@af46b05 |
forking is best! |
This library has been deprecated. Please update to use this new library: |
Note taking... potentially add
Pair
, andConnectProfile
.