Implemented simple chip id and board id caching #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I removed the github tag to automatically close the issue because I want to see if there's any improvements that could be made on the Blinka side first. |
|
Added tag back in. I think this was the most effective change really since Blinka is more of a collection of separate modules rather than a main one that launches stuff. |
ladyada
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #98. This adds a simple caching mechanism by storing the in the class and returning it from cache after the first time. I noted that it went from attempting to detect the FT232H 6 times down to 1 with this strategy when using
import board. The root cause for the issue was that any time we called things like any_raspberry_pi_40_pin, it would have to fetch the chip ID, which was causing it to run all detection routines again. This avoids it unnecessarily running all the routines again, but gives it the value it needs.