Skip to content

Added support for board 'Lemaker Banana Pro' #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2023
Merged

Added support for board 'Lemaker Banana Pro' #305

merged 3 commits into from
Jul 28, 2023

Conversation

Xenokrates
Copy link
Contributor

This pull request adds support for the 'LeMaker Banana Pro' board.
The board is detected via the ARMBIAN release field.
I am not shure wether other OS environments for this board are available, as the LeMaker site seems to be down.

@tekktrik tekktrik requested a review from makermelissa July 23, 2023 20:52
@Xenokrates
Copy link
Contributor Author

Some remarks:

  • This PR is done in preparation for adding the board to Blinka. A board definition for Blinka is in preparation. I still have to do some testing.
  • The LeMaker website seems to be permantently gone.
    • The board descripition for LeMaker Banana Pro can be found here.
    • The board is supported by Armbian.
  • As described in the board description @sunxi.org the "LeMaker Banana Pro" is not the same as the Banana Pi BPI-M1+. The two boards are slightly different and have separate devicetree board definitions in the Linux kernel.

makermelissa
makermelissa approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@makermelissa makermelissa merged commit af62ea4 into adafruit:main Jul 28, 2023
@Xenokrates Xenokrates deleted the bananapro branch August 1, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makermelissa makermelissa makermelissa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xenokrates @makermelissa