Skip to content

Conversation

caternuson
Copy link
Contributor

Add support for Microchip MCP2221 special case controlled by OS environment variable.

NOTE - also reworked the general logic in the "special cases" section to remove the try/except blocks.

@ladyada
Copy link
Member

ladyada commented Nov 21, 2019

needs a lint - also please add a check in the tester sketch that will print out if platformdetect found an mcp2221

@ladyada
Copy link
Member

ladyada commented Nov 21, 2019

@caternuson
Copy link
Contributor Author

Should I have put one of those in for FT232H also?

@ladyada
Copy link
Member

ladyada commented Nov 21, 2019

yah why not :)

@caternuson
Copy link
Contributor Author

I wonder if we should have board.id be something like SPECIAL_CASE for any of these OS env var set cases? And then chip.id would be the actual chip, like FTDI_FT232H and MICROCHIP_MCP2221.

@ladyada
Copy link
Member

ladyada commented Nov 21, 2019

can do that in a future PR - good enough for now!

@ladyada ladyada merged commit 2292125 into adafruit:master Nov 21, 2019
@caternuson
Copy link
Contributor Author

cool. works for me.

i'll bump and release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants