Skip to content

circuitpython_setboard: handle new location of importlib Traversable #10661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2025
Merged

circuitpython_setboard: handle new location of importlib Traversable #10661

merged 1 commit into from
Oct 9, 2025

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Oct 9, 2025 

from importlib.abc import Traversable

was made available as

from importlib.resources.abc import Traversable

in Python 3.11. The old location was deprecated with a warning in 3.13 and removed in 3.14. We support back to 3.9, so try to import in both places.

@dhalbert dhalbert requested a review from FoamyGuy October 9, 2025 16:37
FoamyGuy
FoamyGuy approved these changes Oct 9, 2025
View reviewed changes
Copy link
Collaborator

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

Looks good to me and tested successfully.

@dhalbert dhalbert merged commit 0d88686 into adafruit:main Oct 9, 2025
629 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error running circuitpython_setboard in python 3.14
2 participants
@dhalbert @FoamyGuy