Skip to content

Conversation

hathach
Copy link
Member

@hathach hathach commented Dec 13, 2018

change to use ringbuffer in py/ringbuf.h for uart io. keep DMA incoming byte and put it into fifo.

@hathach hathach requested a review from dhalbert December 13, 2018 16:55
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice - thanks! Tested on PCA10056, works as expected.

I am surprised this technique was not shown as an example somewhere in DevZone.

@dhalbert dhalbert merged commit 5e4b3a8 into adafruit:master Dec 13, 2018
@jerryneedell
Copy link
Collaborator

Works great on my particle argon!

@jerryneedell
Copy link
Collaborator

I can communicate well to an external ESP32 at 115200 baud. And I can talk to the onboard ERC32 even at 921600!! Still working on using the AT commands. Works to external ESP32. Not yet to internal but it’s early!!!

@hathach hathach deleted the nrf_uartio_fix branch February 20, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants