-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix I2SOut message, fix #1765 #1793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@C47D I think you need to run |
Thanks @tannewt, i will try that later today, i thought it was the |
Oh, yup. That is an issue too. The paren needs to be before the MP_QSTR. You likely need to use the _varg variant of the raise too. |
Sorry for the noise, I'm working on a Windows machine so I haven't all the tools to run make translate, I will try to set a VM later this week. |
@C47D No worries! I can fix it for you if that is easiest. I just wanted to give you a shot at it. |
I will try this tutorial and let you know if i have any trouble. |
@tannewt I gave it a shot and failed, I guess it's because I didn't updated my branch since last weekend. |
@C47D Looking now. Thanks! |
a6f2507
to
71c4f10
Compare
Ok, I've rebased the changes. I updated PDMIn to use the same new message and also guessed at the appropriate translation for all of the languages. |
Thanks a lot @tannewt, it seems all good now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you.
No description provided.