Skip to content

Conversation

C47D
Copy link

@C47D C47D commented Apr 14, 2019

No description provided.

@tannewt
Copy link
Member

tannewt commented Apr 15, 2019

@C47D I think you need to run make translate to get the new translation string into the .pot and .po files.

@C47D
Copy link
Author

C47D commented Apr 15, 2019

Thanks @tannewt, i will try that later today, i thought it was the error: too many arguments to function 'translate' causing the Travis errors.

@tannewt
Copy link
Member

tannewt commented Apr 15, 2019

Oh, yup. That is an issue too. The paren needs to be before the MP_QSTR. You likely need to use the _varg variant of the raise too.

@C47D
Copy link
Author

C47D commented Apr 16, 2019

Sorry for the noise, I'm working on a Windows machine so I haven't all the tools to run make translate, I will try to set a VM later this week.

@tannewt
Copy link
Member

tannewt commented Apr 16, 2019

@C47D No worries! I can fix it for you if that is easiest. I just wanted to give you a shot at it.

@C47D
Copy link
Author

C47D commented Apr 16, 2019

I will try this tutorial and let you know if i have any trouble.

@C47D
Copy link
Author

C47D commented Apr 17, 2019

@tannewt I gave it a shot and failed, I guess it's because I didn't updated my branch since last weekend.
If you need this really quick you can take it from here, otherwise I can keep trying to get it to work, I don't want to do lots of commits tho, I don't know if I can squash them.

@tannewt
Copy link
Member

tannewt commented Apr 17, 2019

@C47D Looking now. Thanks!

@tannewt tannewt force-pushed the fix_audiobusio_msg branch from a6f2507 to 71c4f10 Compare April 17, 2019 18:29
@tannewt
Copy link
Member

tannewt commented Apr 17, 2019

Ok, I've rebased the changes. I updated PDMIn to use the same new message and also guessed at the appropriate translation for all of the languages.

@C47D
Copy link
Author

C47D commented Apr 17, 2019

Thanks a lot @tannewt, it seems all good now!

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you.

@tannewt tannewt merged commit 5b94b77 into adafruit:master Apr 17, 2019
@C47D C47D deleted the fix_audiobusio_msg branch April 17, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants