avoid double float arithmetic in FrequencyIn #1855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FrequencyInwas computing afloatin an expression that included auint64_tvalue. This causes software double precision floating arithmetic to be used, which brings a lot of extra code. The difference being calculated is between two closely spaced millisecond time values, so casting to 32 bits should be no problem.Changing the arithmetic to used
uint32_tonly saves about 3000 bytes, which should improve the space squeeze we are seeing on M0 Express builds a lot.Also fixed a minor issue that prevented disabling
puleseio, discovered while I was turning features on and off to find the root cause of the issue.