Skip to content

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Sep 3, 2019

This allows for one to preserve ordering within a Group while
hiding something temporarily.

Fixes #1688

This allows for one to preserve ordering within a Group while
hiding something temporarily.

Fixes micropython#1688
@ladyada
Copy link
Member

ladyada commented Sep 4, 2019

yayy

dhalbert
dhalbert previously approved these changes Sep 4, 2019
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve without the bool:1 changes if you want.

I did some gedanken experiments about hiding and unhiding nested objects in odd orders, and I wasn't able to generate inconsistent states. Looks good!

@tannewt
Copy link
Member Author

tannewt commented Sep 4, 2019

@dhalbert Done and done.

@tannewt
Copy link
Member Author

tannewt commented Sep 4, 2019

Ok, @dhalbert this passes all of the checks now.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, great!

@dhalbert dhalbert merged commit fca440f into adafruit:master Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

displayio - allow ability to hide/show groups
3 participants