Skip to content

workflows: Don't try to upload when running in someone's fork #2296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

jepler
Copy link

@jepler jepler commented Nov 18, 2019

.. which we can tell by whether the environment variable is non-empty.

This fixes a problem where, when I push to my own circuitpython fork, which has actions enabled, I eventually get a failure at the upload step. See e.g., https://github.com/jepler/circuitpython/commit/8e9ac593963537f2504efdfeefe28782de68a53f/checks?check_suite_id=315428254 where all board builds fail at the upload step.

This may only affect users who have deliberately enabled actions within their fork, or maybe actions are still a beta/opt in thing at the user level? For instance, checking another random fork that has recently prepared a pull request, there are no actions that ran in the past: https://github.com/sarfata/circuitpython/actions

.. which we can tell by whether the environment variable is non-empty
@dhalbert
Copy link
Collaborator

This may only affect users who have deliberately enabled actions within their fork, or maybe actions are still a beta/opt in thing at the user level?

I don't have this problem, but I don't have actions enabled on my fork.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@dhalbert dhalbert merged commit 2da1b68 into adafruit:master Nov 18, 2019
@jepler jepler deleted the github-actions-forks branch November 3, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants