Background callback bugfixes #3175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this, a background callback that was on the list when background_callback_reset was called could have ended up in a state that made it "un-queueable": its "prev" pointer could have been non-NULL.
It's perfectly OK for these variables with static linkage to have the same name, but it's inconvenient for humans like me.
if we don't set the flag via accessor fn the tick enable might become wrong
|
I tested out this build on my PyPortal and it does seem to resolve the issue that I noticed on my PyPortal that was noted in #3173 Using this build I can now get into REPL and use it normally with no freezing or crashing of any sort. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #3173 I found that the display would usually stop auto-refreshing after soft reset. This stemmed from not correctly clearing the state of tasks that were queued at that moment. In theory, it could have caused #3173 as well depending on the order in which multiple background callbacks were added, and not happen consistently.
This also fixes a potential problem with framebufferio auto refresh over soft reset, by making the code match displayio.
Testing performed: soft-reset a pygamer repeatedly, both with the auto_refresh flag = True and = False via REPL. Display continued to refresh consistently.