Skip to content

Fix linker error when ONEWIREIO = 0 #5188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Conversation

cwalther
Copy link

Addendum to #5139 to fix linker errors like

arm-none-eabi/bin/ld: firmware.elf.lto.o:(.rodata.busio_module_globals_table+0x1c): undefined reference to `onewireio_onewire_type'

when CIRCUITPY_ONEWIREIO = 0, allowing to actually turn off onewireio (no board currently does that).

This addendum to adafruit#5139 allows actually turning off onewireio. (Not
currently used by any board.)
Copy link
Collaborator

@microdev1 microdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @cwalther.

@microdev1 microdev1 merged commit 1825fc8 into adafruit:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants