Skip to content

Use NO_PIN, not 0, for PDMIn unset pins #5326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Sep 10, 2021

Accidentally disallowed using pin P0_00.

Also:

  • Use NO_PIN, not 0xff for I2SOut (cosmetic fix only; no actual functional change)
  • Add VOLTAGE_MONITOR/BATTERY, ACCELEROMETER_INTERRUPT pins for LED Glasses Driver

Also:
- Use NO_PIN, not 0xff for I2SOut (cosmetic fix only; no actual functional change)
- Add VOLTAGE_MONITOR/BATTERY, ACCELEROMETER_INTERRUPT pins for LED Glasses Driver
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dhalbert dhalbert merged commit 1b5afc0 into adafruit:main Sep 10, 2021
@dhalbert dhalbert deleted the nrf-deinit-pin-fix branch September 10, 2021 19:09
EmergReanimator pushed a commit to EmergReanimator/circuitpython-dut that referenced this pull request Oct 4, 2021
This adds a wlan.config(reconnects=N) option to set the number of reconnect
attempts that will be made if the WLAN connection goes down.  The default
is N=-1 (infinite retries, current behavior).  Setting
wlan.config(reconnects=0) will disable the reconnect attempts.

A nice side effect of reconnects=0 is that wlan.status() will report the
disconnect reason now.  See related issue adafruit#5326.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants