Convert all modules to use MP_REGISTER_MODULE
#5430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert espidf, os, rp2pio, samd and time to use MP_REGISTER_MODULE. Related to #5183.
|
Should modules |
Convert binascii, errno, json, and re to use MP_REGISTER_MODULE. Resolves #5183.
|
Convert binascii, errno, json, and re to use MP_REGISTER_MODULE. Resolves #5183. |
microdev1
changed the title
MP_REGISTER_MODULE
jepler
previously requested changes
Oct 5, 2021
There was a problem hiding this comment.
This looks fine. I didn't test anything.
The test failure is due to the following modules now appearing in the "unix" build, in addition to their u-prefixed forms: 're', 'json', 'binascii', 'errno'. I think this is fine, and the .exp file for this test should simply be updated.
dhalbert
approved these changes
Oct 7, 2021
microdev1
dismissed
jepler’s stale review
Requested changes have been addressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert espidf, os, rp2pio, samd and time to use MP_REGISTER_MODULE.
Related to #5183.