Use mp_arg_validate_type for keyword args
#5452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
approved these changes
Oct 10, 2021
There was a problem hiding this comment.
Thanks for doing this!
I have a not-yet submitted PR that uses the other validators, and uses %q where possibe. I started with all the modules in the smallest SAMD21 builds, hoping to save a few hundred bytes. Unfortunately, it is a few steps forward and a few steps back in many cases, and so far it is only saving a couple of dozen bytes. @jepler had a similar experience.
Diff is main...dhalbert:arg-validation-updates
Even if it doesn't save space, it is more uniform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.