Skip to content

Conversation

kattni
Copy link

@kattni kattni commented Mar 7, 2018

No description provided.

Copy link

@sommersoft sommersoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go at the top of the list? Seems they're all alphabetical with the sensor model #...

@kattni
Copy link
Author

kattni commented Mar 8, 2018

Good call, yes probably.

@sommersoft
Copy link

sommersoft commented Mar 9, 2018

@tannewt calling for an assist. Travis is failing docs, for an odd reason. I've restarted the docs build twice, same result.

Kattni's first commit passed, and nothing changed that I can see other than moving the addition to the beginning of the section.

EDIT/UPDATE:
To give the "larger" picture, my unrelated PR for serial_connected also failed for the same busio/I2C.c problem, along with an additional issue in feather52.

@tannewt
Copy link
Member

tannewt commented Mar 9, 2018

On it. Looks like the register docs removed a reference that the CircuitPython docs link to. Fix is here: adafruit/Adafruit_CircuitPython_Register#13

@tannewt tannewt merged commit f00d281 into adafruit:master Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants