improve start_ap() doc; make "authmode" use consistent internally #8105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
probably a separate issue / PR, but I believe WPA3 is supported now in esp-idf release/v5.1 ...not sure how that maps to CircuitPython releases |
We can add that in 9.0.0; I'll update the doc as necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wifi.radio.start_ap - Cannot set AuthMode because it is not iterable #7680.
Documentation corrections and improvement.
Use
authmodeinstead ofauthmodesinternally. Originally I thought I would rename thestart_ap()keyword argfromauthmodetoauthmodes. But the plural usage is not consistent with the naming used internally in Espressif and Pico W, and elsewhere. An "authmode" can be a combination like WPA/WPA2/PSK.EDIT: forgot to say that I did test this on ESP32-S2.