Don't put comments on mpconfigboard.mk lines; add mistaken flash chip for HalloWing M0 #8669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
reviewed
Nov 29, 2023
| @@ -4,7 +4,10 @@ USB_PRODUCT = "stm32f411ce blackpill" | |||
| USB_MANUFACTURER = "WeAct" | |||
|
|
|||
| # SPI_FLASH_FILESYSTEM = 1 | |||
| # EXTERNAL_FLASH_DEVICES = xxxxxx #See supervisor/shared/external_flash/devices.h for options | |||
|
|
|||
| # See supervisor/shared/external_flash/devices.h for options | |||
There was a problem hiding this comment.
[I know this was already merged, but: I think this comment is out of date, this info is in nvm.toml now]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hallowing M0 Express was supposed to have
adafruit_bus_deviceturned on, but it was not because the line was:The value must be exactly
1when it's checked in the other makefiles, and the comment adds noise (trailing space, I think; the comment may still be removed).Fixed a few other files that potentially had the same problem.
Also adds support for the mistaken Hallowing M0 2MB flash chip (should be 8MB). Only a few of these were shipped.