Switch cyw43-driver to georgerobotics/cyw43-driver tag v1.0.3. #9016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requesting review. Single CI failure looks like the timing related |
tannewt
requested changes
Mar 7, 2024
Branch name is case-sensitive. Co-authored-by: Scott Shawcroft <scott@tannewt.org>
|
It's fine with me to hold this for 9.0.x. There are only a couple of PRs that went into v1.0.3 that weren't already on the Adafruit fork we are currently using, none of them affecting CP. I've manually inspected them, and don't see any issues. In the meantime, I'll switch my work to v1.0.3 and continue testing with it. |
|
@eightycc Did you close this deliberately, or were you just reconstituting your fork? |
|
Cleaning up, didn't realize it would kill the PR. Will resubmit.
…On Fri, Mar 8, 2024 at 7:41 AM Dan Halbert ***@***.***> wrote:
@eightycc <https://github.com/eightycc> Did you close this deliberately,
or were you just reconstituting your fork?
—
Reply to this email directly, view it on GitHub
<#9016 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB5CXR3DFWANJ6HZBZLE23DYXHLZNAVCNFSM6AAAAABEKHABY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBVHEYTMOJTG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch submodule cyw43-driver back to upstream repository at tag v1.0.3.
The additional pulls in our local fork have been merged into the upstream repository. The pulls are: georgerobotics/cyw43-driver#107 and georgerobotics/cyw43-driver#108.