Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add board magiclick_s3_n4r2 & display gc9107 #348

Merged
merged 3 commits into from
Sep 29, 2023
Merged

add board magiclick_s3_n4r2 & display gc9107 #348

merged 3 commits into from
Sep 29, 2023

Conversation

MakerM0
Copy link
Contributor

@MakerM0 MakerM0 commented Sep 27, 2023

Checklist

  • Please provide specific title of the PR describing the change
  • Please provide related links (eg. Issue which will be closed by this Pull Request)
  • If you are adding an new boards, please make sure
    • Provide link to your allocated VID/PID if applicable
    • Add your board to action ci in correct workflow and alphabet order for release binary
    • UF2_BOARD_ID in your board.h follow correct format from uf2 specs

Description of Change

add display gc9107
add board magiclick_s3_n4r2

Board Repo

VID&PID

屏幕截图 27-09-2023 13 41 36

hathach
hathach requested changes Sep 27, 2023
View reviewed changes
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, though the format of board-id is not correct.

ports/espressif/boards/magiclick_s3_n4r2/board.h Outdated Show resolved Hide resolved
hathach
hathach approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect now, thank you

@hathach hathach merged commit 8d1d074 into adafruit:master Sep 29, 2023
105 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hathach hathach hathach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MakerM0 @hathach