Bug/v4 get se element error management #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vexx32
reviewed
Sep 30, 2020
Public/Get-SeElement.ps1
Outdated
|
|
||
| if ($null -eq $Output) { | ||
| $Message = "no such element: Unable to locate element by: $($By -join ',') with value $($Value -join ',')" | ||
| Write-Error -Exception ([System.InvalidOperationException]::new($Message)) |
There was a problem hiding this comment.
What do you think about using [System.Management.Automation.ItemNotFoundException] instead?
IMO InvalidOperation is generally used for things that would never work and can communicate that user input is somehow completely unusable, which doesn't feel like is the case here. 🙂
There was a problem hiding this comment.
@vexx32 Yes, I like yours better.
I used InvalidOperation because that's what the native call produced and didn't have ItemNotFound exception in mind.
Making the change right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#135