Skip to content

Add Hash verification to pester,Update binaries an VirusTotal Scans and Initial Linux/MacOS support. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2019
Merged

Add Hash verification to pester,Update binaries an VirusTotal Scans and Initial Linux/MacOS support. #28

merged 2 commits into from
Aug 14, 2019

Conversation

the-mentor
Copy link
Collaborator

@the-mentor the-mentor commented Aug 13, 2019 •
edited
Loading

  1. Bumped version number to 1.4
  1. Added the Linux and MacOS driver binaries for Chrome and Firefox and Hash Validation.
  2. Updated the WebDriver.dll and WebDriver.Support.dll to the latest stable version 3.141.0
  3. Added missing sha256 files.
  4. Added hash verification to pester tests.
  5. Removed the file InternetExplorerDriver.exe since it seems redundant and IE tests work without it.

@adamdriscoll

@the-mentor
Add Hash verification to pester,Update binaries an VirusTotal Scans
30b2da0 
1) i've updated the WebDriver.dll and WebDriver.Support.dll to the latest stable version 3.141.0
2) I added sha256 files where it was missing.
3) I've added hash verifications to pester tests.
4) i've removed the file InternetExplorerDriver.exe since it seems redundent and IE tests work without it.
@the-mentor
Initial Linux and MacOS support
ee10a64 
1) Bumped version number to 1.4
2) Added the Linux and MacOS driver binaries for Chrome and Firefox and Hash Validation.
3) Added Linux and MacOS driver location detection.
4) Added OS check to Start-SeEdge and Start-SeInternetExplorer Pestor test.
@the-mentor the-mentor changed the title Add Hash verification to pester,Update binaries an VirusTotal Scans Add Hash verification to pester,Update binaries an VirusTotal Scans and Initial Linux/MacOS support. Aug 13, 2019
@adamdriscoll
Copy link
Owner

adamdriscoll commented Aug 14, 2019 •
edited
Loading

Looks good to me! Just gave it a shot on Linux and Windows.

@adamdriscoll adamdriscoll merged commit 4663860 into adamdriscoll:master Aug 14, 2019
@the-mentor
Copy link
Collaborator Author

@adamdriscoll One of my friends with a Mac gave it a shot and he said that it didn't work.
after some troubleshooting it looks like the binaries are not marked as executable.
After he ran chmod +x on the macOS binaries it worked without a hitch so we need to mark them as executable to make this work 100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@the-mentor @adamdriscoll