Fix date handling #113
Closed
Fix date handling #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make a difference between the input date format (as provided to start/end) and the output date format (as included in the output) - input can be local or utc - output can be local (floating) or utc Update tests Update documentation
This was referenced Jun 30, 2019
Merged
…nto fix-date-handling
Not sure this really helps readability or complexity though...
Closed
|
Looking at this asap - thanks for the work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make a difference between the input date format (as provided in
start/endtocreateEvent) and the output date format (as included in the output):Update tests
Update documentation
This fixes the issues introduced by #98 which broke backwards compatibility and conformance with the documentation, as it started interpreting the values passed to
startandendas UTC when the documentation explicitly stated they are local time (and previous versions worked like that), while giving the option of picking other behaviours if needed.