Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UTC-related issues #98

Merged
merged 5 commits into from
Feb 9, 2019
Merged

Fix UTC-related issues #98

merged 5 commits into from
Feb 9, 2019

Conversation

adamgibbons
Copy link
Owner

No description provided.

@adamgibbons adamgibbons merged commit 15ca9cd into master Feb 9, 2019
@adamgibbons adamgibbons deleted the fix/set-date-with-utc-time branch February 9, 2019 22:40
@adamgibbons adamgibbons mentioned this pull request Feb 9, 2019
Closed
This was referenced Jun 27, 2019
Closed
Closed
@jcaron23
Copy link
Contributor

As stated in #108 this has broken compatibility with previous behaviour, and more importantly, with what the documentation states.

The documentation states that start is considered in the local time zone.

Indirectly, createEvent (via formatEvent and setDate) expect the setDateWithUTCtime to take a local time and output an UTC time (contrary to its name), which it did, but now no longer does.

I created a new PR (#113) which:

  • reverts to the previous behaviour
  • gives the option of picking both the input and output formats, for those who want different behaviours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamgibbons @jcaron23