New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove accidental `encodeNewLines` #264

Merged

adamgibbons merged 2 commits into adamgibbons:master from tjenkinson:fix-263

Dec 20, 2023

Contributor

tjenkinson commented Dec 20, 2023 •

edited

setTrigger already handles it.

Fixes #263

tjenkinson added 2 commits

December 20, 2023 12:48


          Remove accidental encodeNewLines

1dfd12e


          Match exact content in test

7ef4db2

adamgibbons merged commit e61714a into adamgibbons:master

Owner

adamgibbons commented Dec 20, 2023

@tjenkinson do you get one failing test for this?

Screen Shot 2023-12-20 at 11 14 10 AM

Contributor Author

tjenkinson commented Dec 20, 2023

Ah no it's a timezone thing again :|

Previously it was fine because it wasn't checking the whole string

renovate bot added a commit to inabagumi/shinju-date that referenced this pull request


          build(deps): update dependency ics to ^3.7.2 (#3770)

75e8ecc

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [ics](https://togithub.com/adamgibbons/ics) | [`^3.7.1` ->
`^3.7.2`](https://renovatebot.com/diffs/npm/ics/3.7.1/3.7.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/ics/3.7.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ics/3.7.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ics/3.7.1/3.7.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ics/3.7.1/3.7.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>adamgibbons/ics (ics)</summary>

### [`v3.7.2`](https://togithub.com/adamgibbons/ics/releases/tag/v3.7.2)

[Compare
Source](https://togithub.com/adamgibbons/ics/compare/ecc8cf54f84da92b3a0fe0fa049fc65cda4d1451...v3.7.2)

#### What's Changed

- Remove accidental `encodeNewLines` by
[@&#8203;tjenkinson](https://togithub.com/tjenkinson) in
[adamgibbons/ics#264

**Full Changelog**:
adamgibbons/ics@v3.7.0...v3.7.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/inabagumi/shinju-date).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment