[pull] canary from vercel:canary #188
Open
+1,427,680
−303,869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
ijjk
force-pushed
the
canary
branch
5 times, most recently
from
df8579c
to
47e5ebe
Compare
ijjk
force-pushed
the
canary
branch
3 times, most recently
from
e078ebe
to
6b863fe
Compare
Co-authored-by: eps1lon <sebastian.silbermann@vercel.com>
The `in_action_fn` state is never used and can be removed. Also renames `action_cnt` to `reference_index` as it will be more general in the future.
## Why? Add an empty bankrupt issues workflow so I can start testing the GitHub Action. ## Changes - Rename `.github/actions/next-repo-info` → `.github/actions/next-repo-actions` - Add `issue_bankrupt.yml` GitHub workflow
* vercel/turbo#8336 <!-- Tobias Koppers - add client disallowed transform -->
### What & Why Fixes NEXT-3498 Fixed loading shows up and disappear during client navigation, when you defined `prefetch` is enabled and slow `generateMetadata` is defined. In #64532, where in layout-router, we removed the place of infinite suspense, adding it back so that the app can still remain suspensy during navigation. #### Behavior before fix Prefetch -> Link Navigation -> Show `loading.js` -> RSC payload fetched (no page content) -> the page content will display later when the promise is resolved #### Behavior after the fix Prefetch -> Link Navigation -> Show `loading.js` -> RSC payload fetched -> suspensy page content still triggering `loading.js` -> display the resolved page content when the promise is resolved --------- Co-authored-by: Zack Tanner <1939140+ztanner@users.noreply.github.com>
This auto-generated PR updates font data with latest available
This test cannot be run in `test-deploy` because it inspects the contents of the `.next` folder.
### What? This makes extracting next/dynamic cheaper when modules have been visited before ### Why? improved HMR and page transitions ### How? All steps for visiting a module are extracted into a single cached function. VIsiting already visited modules costs only a single cache lookup
Co-authored-by: Jiwon Choi <devjiwonchoi@gmail.com>
* vercel/turbo#8546 <!-- Benjamin Woodruff - Decrease default scope_stress test size, add env var config --> * vercel/turbo#8563 <!-- Donny/강동윤 - Update `swc_core` to `v0.95.4` --> * vercel/turbo#8556 <!-- Tobias Koppers - avoid cloning the source code --> * vercel/turbo#8562 <!-- Will Binns-Smith - HMR: handle non-Latin characters in text through base64-encoded sourcemaps --> * vercel/turbo#8530 <!-- Benjamin Woodruff - Support turbo tasks inside of `mod` blocks --> * vercel/turbo#8542 <!-- Benjamin Woodruff - Handle `#[cfg(...)]` attributes on turbo tasks --> * vercel/turbo#8529 <!-- Benjamin Woodruff - Deduplicate persistent task get_function_name logic --> * vercel/turbo#8547 <!-- Benjamin Woodruff - Add new ExitHandler API as an alternative to ExitGuard --> * vercel/turbo#8604 <!-- Benjamin Woodruff - Delete unused TASK_ID_MAPPING support --> * vercel/turbo#8605 <!-- Benjamin Woodruff - Remove nohash-hasher dependency --> * vercel/turbo#8559 <!-- Tobias Koppers - move stateful flag into Done state --> * vercel/turbo#8598 <!-- Tim Neutkens - MDX support: Ensure development transform is only used in development --> * vercel/turbo#8557 <!-- Tobias Koppers - reduce size of task output struct --> * vercel/turbo#8558 <!-- Tobias Koppers - remove prepared task type --> <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
#67150) …d not in another place. "create-next-app" in apostrophe was mentioned twice but one with link and second without link which didn't sync together for me. So, I added the same link to the second one, maybe I am wrong. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation - Run `pnpm prettier-fix` to fix formatting issues before opening the PR. - Read the Docs Contribution Guide to ensure your contribution follows the docs guidelines: https://nextjs.org/docs/community/contribution-guide ### Adding or Updating Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs) - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> Co-authored-by: Jiwon Choi <devjiwonchoi@gmail.com>
Previously, when the provided postponed state was corrupted, the render failed which resulted in a hydration error. Instead, when the postponed state is corrupted, we send the resume stream just for the hydration where it'll attempt to render client side with the data that's already available.
### What? Update the `with-mdx` example to MDX 3. ### Why? The example was 2 major versions behind. ### How? By updating the version in `package.json`. Also the `@mdx-js/react` dependency was removed, as it doesn’t work with the app directory. Users should use `mdx-components.tsx` instead. Refs #59693 Co-authored-by: Sam Ko <sam@vercel.com>
…script (#52845) Co-authored-by: eps1lon <sebastian.silbermann@vercel.com>
Running `pnpx @next/codemod@canary next-dynamic-access-named-export` found the following error ``` Invalid transform choice, pick one of: - name-default-component - add-missing-react-import - withamp-to-config - url-to-withrouter - cra-to-next - new-link - next-og-import - metadata-to-viewport-export - next-image-to-legacy-image - next-image-experimental - built-in-next-font ``` Turns out we're missing it in cli command list
Reverts #62503 This is currently failing tests that use this example [x-ref](https://github.com/vercel/next.js/actions/runs/9699835771/job/26771391310)
These examples are tested, so this ensures tests are run when these examples change to prevent #67249
Fixes some possible race conditions by adding a few delays to the navigation test to ensure that we wait for hydration to occur and prefetches to finish.
## Description This Pull Request improves the visual appearance of the badges in the README.md file by removing unnecessary line breaks between the badge images, eliminating the unwanted blue link lines that previously appeared and resulting in a cleaner and more cohesive look. ### What Removed unnecessary line breaks between badge images in the README.md file to eliminate the unwanted blue link lines and improve the overall visual presentation. ### Why Previously, the badges were displayed with line breaks between them, causing blue link lines to appear, which disrupted the clean look of the badges. By removing these line breaks, the badges now appear without the blue link lines, providing a more cohesive and visually appealing README. ### How - Removed the line breaks between badge images in the README.md file. Co-authored-by: Jiwon Choi <devjiwonchoi@gmail.com>
### Improving Documentation - Just add `'`  Co-authored-by: Jiwon Choi <devjiwonchoi@gmail.com>
When a server action responds with something other than an RSC response, we currently silently ignore the error and it doesn't get propagated to any rejection handlers. This adjusts the handling so that if the server action response is a non-successful status code, we reject the server action promise. If the error is `text/plain`, we'll automatically propagate the text content as the error text. Otherwise, the promise is rejected with a fallback message.
## Why? Notable change of v9 is Corepack is enabled by default. So we can ensure all package manage/resolved exact same version of pnpm. - [**v9.0.0**](https://github.com/pnpm/pnpm/releases/tag/v9.0.0): Discontinued support for Node.js v16 and introduced Corepack compatibility checks. New configuration updates include enabling `dedupe-injected-deps` and changing the lockfile to version 9, with better readability and resistance to Git conflicts. ... - [**v9.4.0**](https://github.com/pnpm/pnpm/releases/tag/v9.4.0) - Kudos to @ryota-murakami for the original :pr:! → #64854 ## Changes - https://pnpm.io/npmrc#link-workspace-packages defaults to `false` now, so setting it to `true` Closes NEXT-3211
## Why?
Add clarification that you need the experimental config:
```
module.exports = withMDX({
experimental: {
mdxRs: true,
},
})
```
when using [Turbopack](https://nextjs.org/docs/architecture/turbopack).
---------
Co-authored-by: Delba de Oliveira <32464864+delbaoliveira@users.noreply.github.com>
Updates data cache docs to reflect `fetch` behavior in Next.js 15 RC. Closes: #67238 --------- Co-authored-by: Sam Ko <sam@vercel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )