Template timezones are off by a day

[diveonebot]

Describe the bug
I came here to search the issues for this exact problem. The date times in the templates are off by exactly 1 full day. I've got the Django settings properly configured to be timezone aware. The best hypothesis I had matches comments in #172 about how momentjs interprets days and Python interpret days. This would make sense (0 == Sunday in moment, 0== Monday in Python -- a full day).

In the event this is happening only in DST areas, the timezone Ive tested it for is America/Los_Angeles

Im running the app in a vanilla Django setup, with the only thing installed is django-appointment. So It should be easily replicable for anyone who installs it.

To Reproduce
Steps to reproduce the behavior:

1. Create an empty django project.
2. Settings :TIME_ZONE = 'America/Los_Angeles' USE_I18N = True USE_L10N = True USE_TZ = True
3. Install this package using the instructions provided.
4. Open the appointments/request/1 page.

Expected behavior
Setting a persons schedule to Sunday and Friday should not appear as Monday and Saturday.

Screenshots
Edit to add screenshot of something interesting I just found while debugging the issue:

Desktop (please complete the following information):

• OS: mac
• Browser firefox

Additional context
I believe its related to one of the problems reported in issue #172

Possible Solution

If you have an idea about what is causing this issue or how to fix it, please let us know.

Can you fix the bug?

• Yes, I can fix the bug and will open a pull request.
• No, I can't fix the bug, but I can assist in testing and providing feedback.
• No, I can't fix the bug, but I can provide more information to help you fix it.
• No, I can't fix the bug, but I can open an issue to report it.

[adamspd]

Hi @diveonebot, I will seriously look into that, thank you for reporting it again.

[diveonebot]

Finally had a little time to test a solution to just remap the days of the week (from what python datetime objects use to what momentjs Date uses).

Within appointments.js I'm testing the following approach:

const dayNumMap = {6: 5, 5: 4, 4: 3, 3: 2, 2: 1, 1: 0, 0: 6};  // from  Py to JS

function reMapDays(dayList, toPy) {
    if (toPy == null) toPy = true;
    return toPy ? dayList.map(day => dayNumMap[day]) : dayList;
}

I successfully did 1 remap to the initial render by applying this to the fetchNonWorkingDays(staffId, cb) function. This only fixes the display of the correct working days. But each update to nonWorkingDays has to correctly re-mapped back and forth. If this bug is indeed just a DST issue, then a map could be the quickest and most direct approach.

That said, I've only got surface experience using momentjs, and zero with the FullCalendar API so I'll have to dig into it to see if thats a workable solution.

[adamspd]

Hi @diveonebot, yes, this could be a workable solution. Thing is, I'm not an expert of full calendar either, I just read the documentation specifically for the things I needed. I'm going to play with the code a little and try to reproduce the issue, if successful, fix it.