Defining the ref callback as a bound method #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanmahajan7
commented
Oct 31, 2018
| @@ -558,10 +558,9 @@ class ReactDataGrid extends React.Component { | |||
| }; | |||
|
|
|||
| getHeaderRows = () => { | |||
| let rows = [{ ref: (node) => this.row = node, height: this.props.headerRowHeight || this.props.rowHeight, rowType: HeaderRowType.HEADER }]; | |||
| const rows = [{ height: this.props.headerRowHeight || this.props.rowHeight, rowType: HeaderRowType.HEADER }]; | |||
There was a problem hiding this comment.
ref: this.row is not used anywhere. Header row defines its own ref.
| render() { | ||
| let headerRows = this.props.headerRows || [{ref: (node) => this.row = node}]; | ||
| let EmptyRowsView = this.props.emptyRowsView; | ||
| const { headerRows } = this.props; |
There was a problem hiding this comment.
| />); | ||
| return ( | ||
| <HeaderRow | ||
| key={row.rowType} |
There was a problem hiding this comment.
Not sure why was key a function (row.ref is defined in ReactDataGrid.js)
malonecj
pushed a commit
that referenced
this pull request
Nov 15, 2018
* Defining the ref callback as a bound method * Fix unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://reactjs.org/docs/refs-and-the-dom.html