Fix outside click logic for committing changes #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runi-B
reviewed
Nov 28, 2018
| handleDocumentClick = (e) => { | ||
| const { target } = e; | ||
| const { container, editor } = this; | ||
| const isClickedInsideEditorContainer = container !== null && (target === container || container.contains(target)); |
There was a problem hiding this comment.
Instead of container !== null && ... could we use one of the below?
Suggested change
| const isClickedInsideEditorContainer = container !== null && (target === container || container.contains(target)); | |
| const isClickedInsideEditorContainer = container && (target === container || container.contains(target)); |
Suggested change
| const isClickedInsideEditorContainer = container !== null && (target === container || container.contains(target)); | |
| const isClickedInsideEditorContainer = !!container && (target === container || container.contains(target)); |
| const { container, editor } = this; | ||
| const isClickedInsideEditorContainer = container !== null && (target === container || container.contains(target)); | ||
| let isClickedInsideEditor = false; | ||
| if (editor !== null) { |
There was a problem hiding this comment.
As above...
Suggested change
| if (editor !== null) { | |
| if (editor) { |
Suggested change
| if (editor !== null) { | |
| if (!!editor) { |
There was a problem hiding this comment.
React will assign the current property with the DOM element when the component mounts, and assign it back to null when it unmounts
I usually prefer an explicit check than using the !! operator but either works
- Fix unit tests
nstepien
approved these changes
Nov 28, 2018
rossjp
pushed a commit
to rossjp/react-data-grid
that referenced
this pull request
Dec 14, 2018
* Fix outside click logic for committing changes * - Cleanup up outside click logic - Fix unit tests * Cleanup up if condition * Add unit tests for editors using portals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.