Cell Tooltip - Focus Issues #1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 5, 2018 17:36
amanmahajan7
approved these changes
Dec 5, 2018
| @@ -32,6 +32,15 @@ | |||
| box-shadow: 2px 0 5px -2px rgba(136, 136, 136, .3) !important; | |||
| } | |||
|
|
|||
| /* cell which have tooltips need to have a higher z-index on hover so that the tooltip appears above the other cells*/ | |||
| .react-grid-Cell.has-tooltip:hover { | |||
| z-index: 5; | |||
There was a problem hiding this comment.
These numbers match the constant values . We need to change it once rc is merged to master
| @@ -365,7 +371,6 @@ class Cell extends React.PureComponent { | |||
| {cellActionButtons} | |||
| {cellExpander} | |||
| {cellContent} | |||
| {tooltip} | |||
There was a problem hiding this comment.
I am still in favor of using a portals for tooltips. To answer your questions from the previous PR
- React uses custom events and use delegation so adding mouse events on each cell will not affect performance. React attaches event handlers on the document to handle this
- We can make tooltips flexible by allowing users to specify tooltip component and just align it with the cell. I will create a POC if I have time
nstepien
approved these changes
Dec 6, 2018
qili26
reviewed
Dec 7, 2018
| @@ -91,7 +91,7 @@ class Row extends React.Component { | |||
| const { colOverscanStartIdx, colOverscanEndIdx, columns } = this.props; | |||
| const frozenColumns = columns.filter(c => columnUtils.isFrozen(c)); | |||
| const nonFrozenColumnsToRender = columns.slice(colOverscanStartIdx, colOverscanEndIdx + 1).filter(c => !columnUtils.isFrozen(c)); | |||
| return frozenColumns.concat(nonFrozenColumnsToRender) | |||
| return nonFrozenColumnsToRender.concat(frozenColumns) | |||
There was a problem hiding this comment.
Is it OK to change the frozen vs non-frozen order?
amanmahajan7
pushed a commit
that referenced
this pull request
Dec 7, 2018
* Cell Tooltip - Focus Issues (#1422) * change level tooltip gets rendered and level it gets triggered * remove unsed editors and fix imports. * re order inclusion of frozen cells to avoid z-index css. * address comments * Revert "remove unsed editors and fix imports." This reverts commit 3b22f60. * fix issues * fix issues * remove extra space * fix: draggable resizing col jumps to right (#1421) * fix: draggable resizing col jumps to right * refactor: use ref instead of findDOMNode * fix: accidentally removed cel * Release 5.0.5 (#1424) * update changelog * Version bump to 5.0.5 [ci skip] * revert auto file changes * address aman comments
rossjp
pushed a commit
to rossjp/react-data-grid
that referenced
this pull request
Dec 14, 2018
* Cell Tooltip - Focus Issues (adazzle#1422) * change level tooltip gets rendered and level it gets triggered * remove unsed editors and fix imports. * re order inclusion of frozen cells to avoid z-index css. * address comments * Revert "remove unsed editors and fix imports." This reverts commit 3b22f60. * fix issues * fix issues * remove extra space * fix: draggable resizing col jumps to right (adazzle#1421) * fix: draggable resizing col jumps to right * refactor: use ref instead of findDOMNode * fix: accidentally removed cel * Release 5.0.5 (adazzle#1424) * update changelog * Version bump to 5.0.5 [ci skip] * revert auto file changes * address aman comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues between cell action and cell tooltips whereby when trying to click on a cell-action the tooltip will show making it very difficult to select the options.
Remove un-referenced editors.
Clean up Frozen column code to get rid of z-index css.