Add aria attributes #2084
Merged
Add aria attributes #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanmahajan7
changed the title
nstepien
reviewed
Jul 20, 2020
src/HeaderCell.tsx
Outdated
Comment on lines
16
to
19
| case 'NONE': | ||
| return 'none'; | ||
| default: | ||
| return undefined; |
There was a problem hiding this comment.
Suggested change
| case 'NONE': | |
| return 'none'; | |
| default: | |
| return undefined; | |
| default: | |
| return 'none'; |
WDYT?
nstepien
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.w3.org/TR/wai-aria-practices/#grid_roles_states_props
https://www.w3.org/TR/wai-aria-practices/#gridAndTableProperties
This improves accessibility of the grid and can potential help with testing (we can use aria-roles/attributes) to find elements. We can further improve it by using
aria-activedescendanthttps://www.w3.org/TR/wai-aria-practices/#kbd_focus_activedescendant